Add endpoint id property to service trait #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the endpointId property to the AWS service trait so that endpoints may be constructed when given a region.
JordonPhillips
force-pushed
the
endpoint-prefix
branch
from
3ce3499 to
48f5459
Compare
srchase
reviewed
Dec 9, 2020
smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/ServiceTrait.java
Outdated
Show resolved
Hide resolved
mtdowling
reviewed
Dec 10, 2020
| The ``endpointPrefix`` property is a ``string`` value that identifies which endpoint | ||
| in a given region should be used to connect to the service. For example, most | ||
| services in the AWS standard partition have endpoints which follow the format: | ||
| ``{endpointPrefix}.{region}.amazonaws.com``. A service with the endpoint id |
There was a problem hiding this comment.
forgot this instance of "endpoint id"
| ``example.us-west-2.amazonaws.com``. For a full listing of possible endpoints, | ||
| check the `AWS Regions and Endpoints`_ page. | ||
|
|
||
| This value is not unique across services and is subject to change. Therefore, |
There was a problem hiding this comment.
Nice. Should we also say that this can be used to attempt to resolve endpoints?
srchase
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This adds the endpointId property to the AWS service trait so that
endpoints may be constructed when given a region.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.