Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous newlines from query tests #815

Merged

Conversation

JordonPhillips
Copy link
Contributor

@JordonPhillips JordonPhillips commented Jun 1, 2021

This removes all the newlines from query formatted bodies in the AWS
protocol tests. While these made the tests easier to read, they
weren't actually valid since a client sending a body formatted that
way would encounter errors.

EC2 formats their docs that way, but they make it clear that it's just for readability:

To make these example requests even easier to read, AWS documentation may present them in the following format:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This removes all the newlines from query formatted bodies in the AWS
protocol tests. While these made the tests easier to read, they
weren't actually valid since a client sending a body formatted that
way would encounter errors.
@JordonPhillips JordonPhillips merged commit ea48c33 into smithy-lang:main Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants