Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Refactor FS Structure #851

Open
sondavidb opened this issue Oct 2, 2023 · 0 comments
Open

[FEATURE] Refactor FS Structure #851

sondavidb opened this issue Oct 2, 2023 · 0 comments
Labels
design feature New feature or request tracking issue Issue that doesn't get worked on directly but tracks overall effort of multiple related issues

Comments

@sondavidb
Copy link
Contributor

sondavidb commented Oct 2, 2023

Description

The current code structure is confusing and is largely inherited from stargz, which in turn attempts to mimic containerd ideas. Due to fundamental differences between SOCI and stargz, we should heavily look into how we structure our codebase to be more clearly aligned with how we want to structure SOCI.

This would avoid problems outlined in various PRs, most recently #849, which mutates multiple function headers to pass a FSConfig all the way down to the layer level, not to mention the many paths it could have taken to get there when it should all be relatively streamlined. If we had clearer abstractions and better mechanisms, it could be a trivial change.

This PR is largely meant to track our plans for design structure for this project going forward.

Describe the solution you'd like

No response

Describe any alternative solutions/features you've considered

No response

Any additional context or information about the feature request

No response

@sondavidb sondavidb added the feature New feature or request label Oct 2, 2023
@github-project-automation github-project-automation bot moved this to ❓ Ungroomed in soci-snapshotter Oct 11, 2023
@Kern-- Kern-- added the design label Oct 11, 2023
@Kern-- Kern-- moved this from ❓ Ungroomed to 📋 Backlog in soci-snapshotter Oct 11, 2023
@Kern-- Kern-- added the tracking issue Issue that doesn't get worked on directly but tracks overall effort of multiple related issues label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design feature New feature or request tracking issue Issue that doesn't get worked on directly but tracks overall effort of multiple related issues
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants