Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): grid template of TwoColumnPageLayout was invalid #291

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

axross
Copy link
Owner

@axross axross commented Mar 29, 2021

No description provided.

@axross axross self-assigned this Mar 29, 2021
@vercel
Copy link

vercel bot commented Mar 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

kohei-dev – ./

🔍 Inspect: https://vercel.com/axross/kohei-dev/8jbbfimRMD29PaWQ7bcQXyhW2R79
✅ Preview: https://kohei-dev-git-fix-page-layout-grid-axross.vercel.app

kohei-dev-storybook – ./

🔍 Inspect: https://vercel.com/axross/kohei-dev-storybook/Eeo8wa2FHMppq1VX5PQy1gM7DJV6
✅ Preview: https://kohei-dev-storybook-git-fix-page-layout-grid-axross.vercel.app

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #291 (fa74afe) into master (8abbd9e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #291   +/-   ##
=======================================
  Coverage   63.70%   63.70%           
=======================================
  Files          36       36           
  Lines         551      551           
  Branches      151      151           
=======================================
  Hits          351      351           
  Misses        197      197           
  Partials        3        3           
Impacted Files Coverage Δ
components/page-layout.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8abbd9e...fa74afe. Read the comment docs.

@axross axross marked this pull request as ready for review March 29, 2021 04:13
@axross axross merged commit d99fcaa into master Mar 29, 2021
@axross axross deleted the fix-page-layout-grid branch March 29, 2021 04:13
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant