Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): add a share button ballon for selected text in articles #301

Merged
merged 1 commit into from
Apr 11, 2021

Conversation

axross
Copy link
Owner

@axross axross commented Apr 11, 2021

Adding a feature that users can select a text in an article to share on twitter, facebook or linkedin

@axross axross self-assigned this Apr 11, 2021
@vercel
Copy link

vercel bot commented Apr 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

kohei-dev – ./

🔍 Inspect: https://vercel.com/axross/kohei-dev/6kPVRmnTc8Yq5RB5hnSbJdkwBxjo
✅ Preview: https://kohei-dev-git-share-balloon-axross.vercel.app

kohei-dev-storybook – ./

🔍 Inspect: https://vercel.com/axross/kohei-dev-storybook/EKEvmM1Lpyy1H95oBGyYsSHB3ozK
✅ Preview: https://kohei-dev-storybook-git-share-balloon-axross.vercel.app

@codecov
Copy link

codecov bot commented Apr 11, 2021

Codecov Report

Merging #301 (cae3259) into master (15374c0) will decrease coverage by 6.46%.
The diff coverage is 3.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
- Coverage   61.68%   55.21%   -6.47%     
==========================================
  Files          39       41       +2     
  Lines         582      661      +79     
  Branches      171      190      +19     
==========================================
+ Hits          359      365       +6     
- Misses        220      291      +71     
- Partials        3        5       +2     
Impacted Files Coverage Δ
services/social-share.ts 0.00% <0.00%> (ø)
components/text-selection-share-balloon.tsx 2.00% <2.00%> (ø)
components/article.tsx 73.68% <33.33%> (-18.63%) ⬇️
components/button-list-balloon.tsx 12.50% <0.00%> (+12.50%) ⬆️
components/balloon.tsx 33.33% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15374c0...cae3259. Read the comment docs.

@axross axross merged commit d6ede8f into master Apr 11, 2021
@axross axross deleted the share-balloon branch April 11, 2021 04:37
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant