feat(form): add setValue method to FormGroup class
#191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for astro-reactive failed.
|
✅ Deploy Preview for astro-reactive-docs canceled.
|
|
Hi @NeilAn99! Thank you for this PR, it looks like you got the solution. There are just some small typescript hiccups 🙂 Can you run |
ayoayco
requested changes
Nov 12, 2022
| @@ -7,6 +7,7 @@ import Form, { | |||
| } from "@astro-reactive/form"; | |||
| import { Validators } from "@astro-reactive/validator"; | |||
| import type { Submit } from "@astro-reactive/common"; | |||
| import { info } from "astro/dist/core/logger/core"; | |||
There was a problem hiding this comment.
I think you can remove this now :)
packages/form/core/form-group.ts
Outdated
Comment on lines
22
to
30
| setValue(values: object) { | ||
| this.controls.map((control) => { | ||
| for (const value in values) { | ||
| if (value == control.name) { | ||
| control.setValue(values[value]); | ||
| } | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
You got the gist of the solution! However, we can still improve this, performance-wise.
Usually, you want to avoid having a loop within a loop for performance. 😉
Try to do this by just looping through the names in your values object and using the FormGroup.get function to get the appropriate control.
Something like:
Object.keys(values).forEach(name => this.get(name)?.setValue(values[name]));There was a problem hiding this comment.
Changed the solution. Thanks for the great suggestion.
|
Made some new commits, let me know if there's anything else I can improve. |
ayoayco
added a commit
that referenced
this pull request
Nov 16, 2022
* feat: install and setup turborepo * chore: update npm scripts to use turbo * chore: add clean scripts * chore: add eslint-config-turbo and update workspace deps * devops: test commit to trigger landing page build and deploy * fix(script): use rimraf instead of 'rm -rf' * chore(docs): change site option (#198) * chore: add test:watch script to turbo * docs: add developing guide * feat(form): add `setValue` method to FormGroup class (#191) * add mastodon ownership verification * chore: change package version to experimental * fix: fix packages/common access Co-authored-by: Ayo <[email protected]> Co-authored-by: Woramat Ngamkham <[email protected]> Co-authored-by: Neil An <[email protected]>
ayoayco
added a commit
that referenced
this pull request
Nov 23, 2022
* feat: install and setup turborepo * chore: update npm scripts to use turbo * chore: add clean scripts * chore: add eslint-config-turbo and update workspace deps * devops: test commit to trigger landing page build and deploy * fix(script): use rimraf instead of 'rm -rf' * chore(docs): change site option (#198) * chore: add test:watch script to turbo * docs: add developing guide * feat(form): add `setValue` method to FormGroup class (#191) * add mastodon ownership verification * chore: change package version to experimental * fix: fix packages/common access Co-authored-by: Ayo <[email protected]> Co-authored-by: Woramat Ngamkham <[email protected]> Co-authored-by: Neil An <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(form): add
setValuemethod to FormGroup classFixes #175
Description of changes:
setValuemethod in the FormGroup class which will set the values for any FormControls in the FormGroup.setValuemethod. For example the following code:will produce the following page:
Tag a reviewer: @ayoayco
Tasks:
npm run buildnpm run testnpm run lint