Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: ZLIB Upgrade #20929

Open
Tracked by #20979
manstfu opened this issue Dec 16, 2024 · 3 comments · May be fixed by #21028
Open
Tracked by #20979

Feature: ZLIB Upgrade #20929

manstfu opened this issue Dec 16, 2024 · 3 comments · May be fixed by #21028

Comments

@manstfu
Copy link
Contributor

manstfu commented Dec 16, 2024

Describe your feature request or suggestion in detail

ZLIB Upgrade to Cloudflare version (https://github.com/cloudflare/zlib)

Describe a possible solution to your feature or suggestion in detail

No response

Additional context

Conclusion: Due to the changes and improvements made, we saw a reduction of approximately 33% in bandwidth, as well as improving overall server performance. We feel much more confident that bandwidth will no longer be an issue in future server launches. Obviously we could always upgrade our bandwidth cap if necessary, but that would have required downtime. Optimizing your code is always the better option.

Source

@TheSCREWEDSoftware
Copy link
Contributor

So this source for the suggestion it's a warmmane post, have you validated the same metrics with azerothcore?

@manstfu
Copy link
Contributor Author

manstfu commented Dec 16, 2024

So this source for the suggestion it's a warmmane post, have you validated the same metrics with azerothcore?

No, but im pretty sure AC is using the default ZLIB.

@heyitsbench
Copy link
Contributor

No, but im pretty sure AC is using the default ZLIB.

Not what he's asking about, and also in the future you should split requests like this into two separate issues, one for zlib upgrade and one for movement batching implementation.

@manstfu manstfu changed the title Feature: ZLIB Upgrade and Optimization Feature: ZLIB Upgrade Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants