Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duelling outside SW does not reset mana while in druid's feral form. #30

Open
Apathyxia opened this issue Apr 3, 2023 · 2 comments
Open

Comments

@Apathyxia
Copy link

When duelling someone outside of Stormwind as a druid and you're in a feral form (cat/bear), the mana is not reset to its maximum value. Health is reset normally. Mana is reset on duel start while in human form.

I did not test boomkin / tree form as I don't have those readily available as of now.

@HasieEST
Copy link

HasieEST commented May 9, 2023

I think this issue might be caused due to this line here:

void DuelReset::SaveManaBeforeDuel(Player* player) {
    if(!player)
        return;

  m_manaBeforeDuel[player] = player->GetPower(POWER_MANA);
}

if i understand it correctly, it tries to get player mana number, but due to being in feral form that doesnt use mana, it can't assign a value to it, thus failing to later reset mana.

Although I can see script checking if player is druid or has power_mana, i am unsure on how druid Power_mana is stored, when it is in feral form(cat or bear)

@pangolp
Copy link
Contributor

pangolp commented Aug 3, 2023

Interesting topic... I would have to investigate more...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants