Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[France] Wrong OfficialHolidays #17

Closed
R2c opened this issue Apr 11, 2016 · 6 comments
Closed

[France] Wrong OfficialHolidays #17

R2c opened this issue Apr 11, 2016 · 6 comments
Assignees
Labels
Milestone

Comments

@R2c
Copy link
Contributor

R2c commented Apr 11, 2016

I have some troubles with France official holidays
The GoodFriday (25-03-2016) and stStephensDay (26-12-2016) aren't official holidays
It's true for "Alsace-Moselle" but not for all France

Nice idea this lib 👍

@stelgenhof
Copy link
Member

Thanks for the feedback. Let me have a look. It has been a while when France was added :)

@stelgenhof
Copy link
Member

Just checked and you are right. In case a country has regional holidays I implement separate regional holiday providers. Since that takes a bit more time, I will remove these two holidays then from France. Later will add a separate holiday provider for Alsace and Moselle.

@stelgenhof stelgenhof added the bug label Apr 11, 2016
@stelgenhof stelgenhof added this to the v1.3.0 milestone Apr 11, 2016
@stelgenhof
Copy link
Member

@R2c Looking on the page https://fr.wikipedia.org/wiki/F%C3%AAtes_et_jours_f%C3%A9ri%C3%A9s_en_France#Tableau_r.C3.A9capitulatif I don't see Alsace, but do see Moselle mentioned. In France are some holidays observed by département or rather region?

@R2c
Copy link
Contributor Author

R2c commented Apr 11, 2016

In France are some holidays observed by département or rather region?
No, but we have just one expection for 3 départements "Moselle, du Bas-Rhin, du Haut-Rhin".
Bas-Rhin, du Haut-Rhin == Alsace

"I will remove these two holidays then from France. Later will add a separate holiday provider for Alsace and Moselle."
👍 👍

@stelgenhof
Copy link
Member

Thanks! Let me then add separate holiday providers by département (similar to the Spain implementation).

@stelgenhof stelgenhof self-assigned this Apr 11, 2016
@stelgenhof
Copy link
Member

Fixed issue for France as Good Friday and St. Stephens Day were defined as official holidays. These aren't national holidays and are only observed in the French departments Moselle, Bas-Rhin and Haut-Rhin. With this fix, these holidays have been removed from the France Holiday providers and new providers for the departments Moselle, Bas-Rhin and Haut-Rhin are added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants