-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[France] Wrong OfficialHolidays #17
Comments
Thanks for the feedback. Let me have a look. It has been a while when France was added :) |
Just checked and you are right. In case a country has regional holidays I implement separate regional holiday providers. Since that takes a bit more time, I will remove these two holidays then from France. Later will add a separate holiday provider for Alsace and Moselle. |
@R2c Looking on the page https://fr.wikipedia.org/wiki/F%C3%AAtes_et_jours_f%C3%A9ri%C3%A9s_en_France#Tableau_r.C3.A9capitulatif I don't see Alsace, but do see Moselle mentioned. In France are some holidays observed by département or rather region? |
In France are some holidays observed by département or rather region? "I will remove these two holidays then from France. Later will add a separate holiday provider for Alsace and Moselle." |
Thanks! Let me then add separate holiday providers by département (similar to the Spain implementation). |
Fixed issue for France as Good Friday and St. Stephens Day were defined as official holidays. These aren't national holidays and are only observed in the French departments Moselle, Bas-Rhin and Haut-Rhin. With this fix, these holidays have been removed from the France Holiday providers and new providers for the departments Moselle, Bas-Rhin and Haut-Rhin are added. |
I have some troubles with France official holidays
The GoodFriday (25-03-2016) and stStephensDay (26-12-2016) aren't official holidays
It's true for "Alsace-Moselle" but not for all France
Nice idea this lib 👍
The text was updated successfully, but these errors were encountered: