You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think the holiday calculation functions in the provider classes should be protected instead of private (as discussed here #276), this would make it much easier to extend the current providers as I don't have to copy-paste functions from the parent class to use them in extending class. For example:
Hi @attepulkkinen Thank you very much for raising this. Indeed as per the #276 discussion, these methods can be changed to protected. I haven't actively changed this for all the providers (yet).
I would indeed appreciate if you could create a PR for this.
I think the holiday calculation functions in the provider classes should be protected instead of private (as discussed here #276), this would make it much easier to extend the current providers as I don't have to copy-paste functions from the parent class to use them in extending class. For example:
yasumi/src/Yasumi/Provider/Finland.php
Line 153 in 59e2bf6
yasumi/src/Yasumi/Provider/Greece.php
Line 114 in 59e2bf6
yasumi/src/Yasumi/Provider/Luxembourg.php
Line 109 in 59e2bf6
I can provide pull-request if needed
The text was updated successfully, but these errors were encountered: