Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holiday calculation functions in providers are private, could those be protected instead? #331

Closed
attepulkkinen opened this issue Jan 15, 2024 · 1 comment · Fixed by #332

Comments

@attepulkkinen
Copy link
Contributor

I think the holiday calculation functions in the provider classes should be protected instead of private (as discussed here #276), this would make it much easier to extend the current providers as I don't have to copy-paste functions from the parent class to use them in extending class. For example:

private function calculateIndependenceDay(): void

private function calculateCleanMonday(): void

private function calculateNationalDay(): void

I can provide pull-request if needed

@stelgenhof
Copy link
Member

Hi @attepulkkinen Thank you very much for raising this. Indeed as per the #276 discussion, these methods can be changed to protected. I haven't actively changed this for all the providers (yet).

I would indeed appreciate if you could create a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants