Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bank holidays in United Kingdom #64

Closed
AlirezaAlgo opened this issue Sep 11, 2017 · 2 comments
Closed

Bank holidays in United Kingdom #64

AlirezaAlgo opened this issue Sep 11, 2017 · 2 comments
Assignees
@stelgenhof
Labels
bug
Milestone
v1.7.0

Comments

@AlirezaAlgo
Copy link

Your package return this holidays for united kingdom:
array:7 [▼
"newYearsDay" => "2017-01-02"
"goodFriday" => "2017-04-14"
"easterMonday" => "2017-04-17"
"mayDayBankHoliday" => "2017-05-01"
"springBankHoliday" => "2017-05-29"
"christmasDay" => "2017-12-25"
"secondChristmasDay" => "2017-12-26"
]
but refer to https://www.gov.uk/bank-holidays holidays must be 8 days for 2017!
@AlirezaAlgo AlirezaAlgo changed the title Bank holydays in United Kingdom Bank holidays in United Kingdom Sep 11, 2017
@stelgenhof
Copy link
Member

Thanks for catching this. Indeed it seems that the Summer Bank Holiday is missing.

@stelgenhof stelgenhof added the bug label Sep 11, 2017
@stelgenhof stelgenhof added this to the v1.7.0 milestone Sep 11, 2017
@stelgenhof stelgenhof self-assigned this Sep 11, 2017
@stelgenhof
Copy link
Member

@serverfire Added the missing Summer Bank Holiday. Would you mind checking again using the latest commit? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stelgenhof stelgenhof

Labels
bug
Projects
None yet
Milestone
v1.7.0
Development

No branches or pull requests
2 participants
@AlirezaAlgo @stelgenhof