From d1f52f565518d0dbd82c2ef8928203a66209e1c5 Mon Sep 17 00:00:00 2001 From: bruce aldridge Date: Mon, 16 Dec 2019 09:16:21 +1300 Subject: [PATCH 1/4] Add AFL Grand Final Friday dates for 2019 / 2020 sources 2019: https://www.timeanddate.com/holidays/australia/afl-grand-final-friday 2020: https://publicholidays.com.au/afl-grand-final-holiday/ --- src/Yasumi/Provider/Australia/Victoria.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/Yasumi/Provider/Australia/Victoria.php b/src/Yasumi/Provider/Australia/Victoria.php index e158d9e6e..1b69822f7 100644 --- a/src/Yasumi/Provider/Australia/Victoria.php +++ b/src/Yasumi/Provider/Australia/Victoria.php @@ -194,6 +194,12 @@ private function calculateAFLGrandFinalDay(): void case 2018: $aflGrandFinalFriday = '2018-09-28'; break; + case 2019: + $aflGrandFinalFriday = '2019-09-27'; + break; + case 2020: + $aflGrandFinalFriday = '2018-09-25'; + break; default: return; } From 989cf514cbe18397f550ab24e98cf697cf1e3abc Mon Sep 17 00:00:00 2001 From: bruce aldridge Date: Tue, 17 Dec 2019 09:00:41 +1300 Subject: [PATCH 2/4] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e6aed3c6b..89e1fec54 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/) and this ## [Unreleased] ### Added - +- Additional Dates for Australia/Victoria:AFL Grand Final Friday [\#190](https://github.com/azuyalabs/yasumi/pull/190) ([brucealdridge](https://github.com/brucealdridge)) ### Changed ### Fixed From ed953eaf1a43590c25f7e43a8bfa42a64535c4af Mon Sep 17 00:00:00 2001 From: bruce aldridge Date: Tue, 17 Dec 2019 09:02:35 +1300 Subject: [PATCH 3/4] Update AFLGrandFinalFridayTest.php Adding test cases --- tests/Australia/Victoria/AFLGrandFinalFridayTest.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/Australia/Victoria/AFLGrandFinalFridayTest.php b/tests/Australia/Victoria/AFLGrandFinalFridayTest.php index 303ce70aa..09760f0fd 100644 --- a/tests/Australia/Victoria/AFLGrandFinalFridayTest.php +++ b/tests/Australia/Victoria/AFLGrandFinalFridayTest.php @@ -30,7 +30,7 @@ class AFLGrandFinalFridayTest extends VictoriaBaseTestCase implements YasumiTest public const HOLIDAY = 'aflGrandFinalFriday'; public const ESTABLISHMENT_YEAR = 2015; - public const LAST_KNOWN_YEAR = 2018; + public const LAST_KNOWN_YEAR = 2020; /** * Tests AFL Grand Final Friday @@ -103,6 +103,8 @@ public function HolidayDataProvider(): array [2016, '2016-09-30'], [2017, '2017-09-29'], [2018, '2018-09-28'], + [2019, '2019-09-27'], + [2020, '2020-09-25'], ]; return $data; From 59f80448689fc0bc54190e7545c4bcc27066e20b Mon Sep 17 00:00:00 2001 From: bruce aldridge Date: Tue, 17 Dec 2019 09:03:38 +1300 Subject: [PATCH 4/4] Updating copy/pasted year --- src/Yasumi/Provider/Australia/Victoria.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Yasumi/Provider/Australia/Victoria.php b/src/Yasumi/Provider/Australia/Victoria.php index 1b69822f7..77dd6ef8f 100644 --- a/src/Yasumi/Provider/Australia/Victoria.php +++ b/src/Yasumi/Provider/Australia/Victoria.php @@ -198,7 +198,7 @@ private function calculateAFLGrandFinalDay(): void $aflGrandFinalFriday = '2019-09-27'; break; case 2020: - $aflGrandFinalFriday = '2018-09-25'; + $aflGrandFinalFriday = '2020-09-25'; break; default: return;