Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skillet conflicts with addon All the Things #8

Closed
ishirra opened this issue Feb 22, 2021 · 1 comment
Closed

Skillet conflicts with addon All the Things #8

ishirra opened this issue Feb 22, 2021 · 1 comment

Comments

@ishirra
Copy link

ishirra commented Feb 22, 2021

I am using version 4.24 (image says 4.22 but it was taken before I updated the addon)
I have addon All The Things, it gives a window next to the crafting window, to see which recipes I can still get etc.
When Skillet is turned off the window does what it's supposed to do, when Skillet is loaded the window is stuck in the middle of my screen, unmovable and blocking my view and it stops me from being able to click things

image

@b-morgan
Copy link
Owner

b-morgan commented Feb 22, 2021

Skillet doesn't cause this behavior, All The Things attaches its frame to Blizzard's (hidden and unmovable) TradeSkillFrame (Skillet IS responsible for hiding the Blizzard TradeSkillFrame). The following change to AllTheThings.lua starting at line 14901 will get you most of the way there.

			elseif SkilletFrame then
				self:SetPoint("TOPLEFT", SkilletFrame, "TOPRIGHT", 0, 0);
				self:SetPoint("BOTTOMLEFT", SkilletFrame, "BOTTOMRIGHT", 0, 0);
				self:SetMovable(true);
			elseif TradeSkillFrame then
				-- Default Alignment on the WoW UI.
				self:SetPoint("TOPLEFT", TradeSkillFrame, "TOPRIGHT", 0, 0);
				self:SetPoint("BOTTOMLEFT", TradeSkillFrame, "BOTTOMRIGHT", 0, 0);
				self:SetMovable(false);

ATTWoWAddon/AllTheThings#705 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants