Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for clojure.datafy #344

Closed
cldwalker opened this issue Jun 11, 2020 · 1 comment
Closed

Support for clojure.datafy #344

cldwalker opened this issue Jun 11, 2020 · 1 comment

Comments

@cldwalker
Copy link

Hi. Exciting that defprotocol support is out! I'm opening this issue to track support for clojure.datafy.

Soon after defprotocol support landed on master, I tried requiring clojure.datafy and ran into missing java classes e.g. Unable to resolve classname: java.lang.Iterable [at clojure/core/protocols.clj, line 34, column 6]. Here's what I tried to remedy missing java classes:

  • I added all the new java classes I could find in clojure.datafy
  • I successfully built bb locally with uberjar and compile scripts. I'm on osx with the right versions of java and graalvm.
  • After starting up a bb repl, (require 'clojure.datafy) results in this new failure: java.lang.IllegalArgumentException: Don't know how to create ISeq from: clojure.lang.Keyword [at clojure/core/protocols.clj, line 182, column 1]. The source of the error points to defprotocol

It's unclear to me if I'm adding java classes in the wrong places in src/babashka/impl/classes.clj, if there's a sci issue with defprotocol or something else. Any thoughts?

Is your feature request related to a problem? Please describe.
Would like to use clojure.datafy for navigating data and java classes because of its first class reach in the language

Describe the solution you'd like
Would like require clojure.datafy to work

Describe alternatives you've considered
There isn't another that has the same functionality and is built into the language

Additional context
n/a

@cldwalker
Copy link
Author

Oops. Meant to open this in babashka. Closing and reopening there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant