Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define storage specs as URIs (ipfs://, http://, git://, s3://...) instead of different arguments #1971

Closed
wdbaruni opened this issue Feb 16, 2023 · 5 comments · Fixed by #2155
Assignees

Comments

@wdbaruni
Copy link
Member

No description provided.

@wdbaruni wdbaruni changed the title Defining storage specs as URIs (ipfs://, http://, git://, s3://...) instead of different arguments Define storage specs as URIs (ipfs://, http://, git://, s3://...) instead of different arguments Feb 16, 2023
@js-ts js-ts self-assigned this Mar 3, 2023
@js-ts
Copy link
Contributor

js-ts commented Mar 3, 2023

@wdbaruni @simonwo I think it will make things much simpler for the users
since most of the other shorthand flags are already being used '-m' seems the best option

Storage type command
ipfs bacalhau docker run -m ipfs://
url bacalhau docker run -m http://
inline bacalhau docker run -m file://
repo bacalhau docker run -m git://

@js-ts
Copy link
Contributor

js-ts commented Mar 3, 2023

If I'm not wrong the plan is to eventually deprecate all the flags

@wdbaruni
Copy link
Member Author

wdbaruni commented Mar 7, 2023

Thanks for picking this up @js-ts. I don't think we need a new flag for this. The goal is to have existing --inputs and --outputs accept URIs, which should allow us to deprecate --input-urls, and I am not sure why we have a separate --input-volumes. Also I am not sure I understand your last comment about deprecating all flags

@js-ts
Copy link
Contributor

js-ts commented Mar 7, 2023

-outputs accept URIs
how could output volumes accept URIs ?

--inputs accept URIs
I wanted to keep all the existing flags working so decided on a new flag

I am not sure I understand your last comment about deprecating all flags
ok I thought we wanted to deprecate those flags and them with a single flag

@enricorotundo
Copy link
Contributor

FYI In #945 we've been talking about supporting multiple values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants