feat: improve error handling and logging in the compute package #4850
Conversation
|
Warning Rate limit exceeded@virajbhartiya has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 16 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
WalkthroughThis pull request refines the error handling across the compute package. In the bidder module, error checks now distinguish specific error types, and additional logging is implemented. In the executor watcher, errors during bidding, execution, and cancellation are handled with improved logging and corresponding metric increments. Additionally, three new error metrics are introduced in the metrics file to track execution errors more closely. Changes
Sequence Diagram(s)sequenceDiagram
participant B as Bidder
participant S as Store
participant L as Logger
B->>S: UpdateExecutionState()
alt Error is ErrInvalidExecutionState
B->>L: Log debug: "Skipping update owing to invalid state"
else Other error encountered
B->>B: Call handleError()
Note right of B: Update execution state to failed
B->>L: Log detailed error if failErr exists
end
sequenceDiagram
participant E as ExecutionUpsertHandler
participant O as Operation
participant M as Metrics
participant L as Logger
E->>O: Perform bidding/execution/cancellation
alt Error occurs during operation
E->>M: Increment corresponding error metric
E->>L: Log error with execution ID & state details
else No error
E->>E: Continue normal flow
end
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@wdbaruni Can you please take a look at this |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
pkg/compute/bidder.go(2 hunks)pkg/compute/metrics.go(1 hunks)pkg/compute/watchers/executor_watcher.go(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: testcontainers-suite / tests
🔇 Additional comments (2)
pkg/compute/watchers/executor_watcher.go (1)
33-36: LGTM! Well-structured logging setup.The logger is properly configured with relevant context fields that will help with debugging and tracing issues.
pkg/compute/bidder.go (1)
223-232: LGTM! Robust error type handling.Good use of error type assertion to handle invalid state errors gracefully. The debug logging provides excellent context for troubleshooting.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Closes #4684 #4849
This pull request includes several changes to improve error handling and logging in the compute package. The most important changes include adding error metrics, handling specific error cases, and enhancing logging to provide more detailed information.
Error Handling Improvements:
pkg/compute/bidder.go: Improved error handling in thehandleBidResultfunction by checking for specific error types and logging detailed messages.Logging Enhancements:
pkg/compute/watchers/executor_watcher.go: Enhanced logging in theHandleEventfunction to include execution ID and state, and added error logging for bidding, running, and cancellation errors.Metrics Addition:
pkg/compute/metrics.go: Added new metrics to track errors encountered during execution bidding, running, and cancellation.Miscellaneous Changes:
cmd/cli/config/list.go: Updated the table column configuration to include a maximum width and a soft wrap for the "Value" column.pkg/compute/bidder.go: Added theerrorspackage import to handle error type assertions.pkg/compute/watchers/executor_watcher.go: Added thezerolog/logpackage import for enhanced logging.Summary by CodeRabbit
Bug Fixes
New Features
Refactor