Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: consistent output suffixes in ska weed #64

Closed
rderelle opened this issue Jan 5, 2024 · 1 comment · Fixed by #66
Closed

Suggestion: consistent output suffixes in ska weed #64

rderelle opened this issue Jan 5, 2024 · 1 comment · Fixed by #66
Assignees
Labels
enhancement New feature or request

Comments

@rderelle
Copy link
Collaborator

rderelle commented Jan 5, 2024

Not an issue per se.

I noticed that the commands 'build' and 'merge' seem to systematically add a '.skf' extension to the output name file while the command 'weed' does not.

For instance, the command 'ska build -o name_file.skf' generates a file 'name_file.skf.skf' while the command 'ska weed -o name_file.skf' generates a file 'name_file.skf'.

@johnlees
Copy link
Member

johnlees commented Jan 5, 2024

Good spot, I will improve this in the next release – I think the weed behaviour is better (checking for .skf and not adding if already there)

@johnlees johnlees changed the title non consistent output names Suggestion: consistent output suffixes in ska weed Feb 12, 2024
@johnlees johnlees self-assigned this Feb 12, 2024
@johnlees johnlees added the enhancement New feature or request label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants