Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional output filename option -o to ska weed. #55

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

tmaklin
Copy link
Collaborator

@tmaklin tmaklin commented Sep 22, 2023

Adds an optional output filename argument to ska weed. Default behavior still is to overwrite the input but the new argument adds some flexibility. This may be useful to people who don't want to overwrite their inputs.

@johnlees
Copy link
Member

Seems like a very sensible addition – not sure why the tests aren't running though, maybe some github branch thing I've set up wrong. I've added you as a collaborator now if you want to use an internal branch.
You also need to bump the version number to pass that test.
If you don't have time I can sort this out in the next few weeks (travelling for a while)

@tmaklin
Copy link
Collaborator Author

tmaklin commented Sep 22, 2023

thanks, I'll give it a try

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.10% ⚠️

Comparison is base (7237159) 92.51% compared to head (1a061af) 92.42%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   92.51%   92.42%   -0.10%     
==========================================
  Files          16       16              
  Lines        2192     2152      -40     
==========================================
- Hits         2028     1989      -39     
+ Misses        164      163       -1     
Files Changed Coverage Δ
src/cli.rs 73.96% <50.00%> (-0.45%) ⬇️
src/lib.rs 80.94% <100.00%> (-0.86%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@johnlees johnlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Don't know why test jobs didn't run, but codecov did so that means they are passing. Thanks for the contribution!

@johnlees johnlees merged commit 4eb1446 into bacpop:master Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants