Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ska delete #58

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Fix for ska delete #58

merged 5 commits into from
Oct 4, 2023

Conversation

johnlees
Copy link
Member

@johnlees johnlees commented Oct 4, 2023

Silly mistake in the loop that does the deletion which I'm surprised wasn't caught by the tests, maybe need to review these.

Closes #57

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4eb1446) 92.42% compared to head (247b24d) 92.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   92.42%   92.50%   +0.08%     
==========================================
  Files          16       16              
  Lines        2152     2176      +24     
==========================================
+ Hits         1989     2013      +24     
  Misses        163      163              
Files Coverage Δ
src/generic_modes.rs 100.00% <ø> (ø)
src/merge_ska_array.rs 99.65% <100.00%> (+0.77%) ⬆️
src/ska_ref.rs 96.22% <100.00%> (-0.02%) ⬇️
src/lib.rs 80.63% <85.71%> (-0.31%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnlees johnlees merged commit dd2c90a into master Oct 4, 2023
@johnlees johnlees deleted the i57-delete-fix branch October 4, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ska merge and delete not working
1 participant