-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated skalo with indel output #91
Conversation
rderelle
commented
Feb 9, 2025
- better sorting of indel groups
- output indel VCF file
- fixed detection of internal indel k-mers (but slow)
- changed default m value to 0.1 for consistency with ska align
- updated doc and a few log::info messages
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 93.43% 94.41% +0.98%
==========================================
Files 24 25 +1
Lines 3943 4098 +155
==========================================
+ Hits 3684 3869 +185
+ Misses 259 229 -30 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly looks good. Did you run cargo fmt
?
Can you also add a test that the indels are output, as you did for the SNPs?
@johnlees I added a test file for indel prediction/output. All done. |
Looks good thanks. I have run I'll merge this when the tests pass again. When I do, would you be ready for me to release this as v0.4.0? |