Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated skalo with indel output #91

Merged
merged 13 commits into from
Feb 10, 2025
Merged

updated skalo with indel output #91

merged 13 commits into from
Feb 10, 2025

Conversation

rderelle
Copy link
Collaborator

@rderelle rderelle commented Feb 9, 2025

  • better sorting of indel groups
  • output indel VCF file
  • fixed detection of internal indel k-mers (but slow)
  • changed default m value to 0.1 for consistency with ska align
  • updated doc and a few log::info messages

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 96.75926% with 7 lines in your changes missing coverage. Please review.

Project coverage is 94.41%. Comparing base (3ce160e) to head (e6fe692).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
src/skalo/process_indels.rs 97.04% 6 Missing ⚠️
src/lib.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   93.43%   94.41%   +0.98%     
==========================================
  Files          24       25       +1     
  Lines        3943     4098     +155     
==========================================
+ Hits         3684     3869     +185     
+ Misses        259      229      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@johnlees johnlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly looks good. Did you run cargo fmt?

Can you also add a test that the indels are output, as you did for the SNPs?

@rderelle
Copy link
Collaborator Author

@johnlees I added a test file for indel prediction/output. All done.

@johnlees
Copy link
Member

Looks good thanks. I have run cargo fmt, and also updated the tests so that they actually compare against your correct results files.

I'll merge this when the tests pass again. When I do, would you be ready for me to release this as v0.4.0?

@johnlees johnlees merged commit 9483f03 into master Feb 10, 2025
9 checks passed
@johnlees johnlees deleted the skalo-update branch February 10, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants