Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leaks #1880

Closed
maksymshtyria opened this issue Jun 23, 2014 · 8 comments
Closed

Memory leaks #1880

maksymshtyria opened this issue Jun 23, 2014 · 8 comments

Comments

@maksymshtyria
Copy link

We have some sails application which have been deployed on DigitalOcean. Sometimes we are checking with newrelic how it is working.
After we have started load tests on our app we have found out that our app has memory leaks. For example we have created test where 2000 users are trying to get static pages about 2000 times. After perform this operation memory have grew a lot.

My questions is - have you checked sails on memory leaks? Maybe you know how we can find them (in node js) or probably places where you think them can be.

Thx.

@mdunisch
Copy link
Contributor

Hi,
because you tested static files: Sails uses Express.static() to serve static-files. Maybe you could run the test again the only with express-static?

Example script for a express-static-server:

var express = require('express');
var app = express();
app.use(express.compress());
app.use(express.static(__dirname + '/assets', { maxAge: 31557600000 }));
app.listen(1337);

Note: Please use "express": "3.4.3" - it's the same version sails uses.

@maksymshtyria
Copy link
Author

Thx - I`ll try it. But the main question was about leaks. We have started our testing from static pages, but next we created test where the same 2000 guys are trying to login and perform some basic operations.

In this case we got a huge increase of memory. GC was trying to clear but every time 40-50 mb are increased.

I can show real information if it need.

@CWyrtzen
Copy link

CWyrtzen commented Jul 8, 2014

@maksymshtyria did you find a solution?

@CWyrtzen CWyrtzen added this to the Waiting on reply from OP milestone Jul 8, 2014
@RWOverdijk
Copy link
Contributor

@maksymshtyria Did you find more info? This is a pretty serious claim so I'd like more info.

@CWyrtzen
Copy link

This has been marked for testing and any community feedback is welcomed~

@CWyrtzen
Copy link

With no reply from the OP for almost a month I have to assume this is no longer an issue. I am going to close it up but, of course, it can be reopened at any time~

Sails v0.10 is here: Upgrade | Contribution Guide | Stackoverflow | Google Group | IRC | Build Status

@CWyrtzen CWyrtzen removed this from the Waiting on response from OP milestone Aug 11, 2014
@ivkalita
Copy link

Well, I have sails.js application, and have found that it has some memory leak. I'm using pm2 monit command for testing application memory usage. My application using postgresql as database back-end and redis as sessions storage. I try to open static page (default sails homepage), and each time I have opened it, used memory size increased by 80-90 KB. Of course it is production environment. Any ideas?

@mikermcneil
Copy link
Member

For future reference, there's more information and tips on diagnosing memory leaks in Node apps, and on reproducing+reporting suspected memory leaks in Sails here:
#3782 (comment)

@balderdashy balderdashy locked and limited conversation to collaborators Aug 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

7 participants