Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider providing yarn as part of the base image #206

Closed
emirotin opened this issue Nov 7, 2016 · 5 comments
Closed

Consider providing yarn as part of the base image #206

emirotin opened this issue Nov 7, 2016 · 5 comments

Comments

@emirotin
Copy link

emirotin commented Nov 7, 2016

https://yarnpkg.com/ is a modern npm client replacement from Facebook, Google, et. al.
Providing it pre-packaged is a matter of npm install -g, but should make our images look way more modern.
Would probably only make sense for node >= 4

@Page-
Copy link
Contributor

Page- commented Nov 7, 2016

Do you happen to know how big yarn is? For the sake of the slim images I'd say we should leave it out regardless (should be bare minimum), but it'd be nice to know the cost for other images as well

@nghiant2710
Copy link
Contributor

there is a PR for it in official repo nodejs/docker-node#260 but it's not merged yet. We will consider including it when it's approved in upstream repository, I think

@emirotin
Copy link
Author

emirotin commented Nov 7, 2016

OK, it's not that small:

du -sh ~/.nvm/versions/node/v6.5.0/lib/node_modules/yarn
 24M    /Users/eugene/.nvm/versions/node/v6.5.0/lib/node_modules/yarn

As a side not we don't have to wait for the official image change, as I said it can easily be done with a single extra RUN command.

@nghiant2710
Copy link
Contributor

I meant it's still controversial whether should it be used and how to add it into the base images. So it's better to wait a bit and see how it goes

@petrosagg
Copy link
Contributor

@emirotin to give some context, the reason we wait for upstream is because we want to be as aligned as possible with Docker's base images to give our users a familiar environment to work in. Granted this is a pure addition, but still an interface that we'll have to maintain if added.

Regarding the size, ouch :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants