Deny preload for an image with secure boot enabled #2914
Conversation
kb2ma
force-pushed
the
deny-preload-sb
branch
from
3d36582 to
a1650aa
Compare
Change-type: patch Signed-off-by: Ken Bannister <[email protected]>
kb2ma
force-pushed
the
deny-preload-sb
branch
from
a1650aa to
a02df07
Compare
kb2ma
changed the title
| BalenaPartition.ROOTA, | ||
| async (fs: typeof Fs): Promise<boolean> => { | ||
| try { | ||
| const promiseDir = promisify(fs.readdir); |
There was a problem hiding this comment.
Maybe instead of using promisify here, we can use the native promises api: https://nodejs.org/docs/latest-v20.x/api/fs.html#fspromisesreaddirpath-options to avoid having to do this?
There was a problem hiding this comment.
@rcooke-warwick this is not the fs namespace imported at the top level, but it's the virtual fs "namespace" that balena-image-fs gives us.
That being said, since we recently added support for promises in balena-image-fs, @kb2ma should be able to just use v directly.
| const promiseDir = promisify(fs.readdir); | |
| const files = await fs.promises.readdir('/opt'); |
| }, | ||
| ); | ||
| // Next verify that config.json enables secureboot. | ||
| if (isSecureBoot) { |
There was a problem hiding this comment.
Not relevant to this PR, but maybe elsewhere we can add a check to the CLI that detects if someone has tried to enable secureboot on a non signed image, and warn them that this won't work, to avoid any confusion / chance of them thinking they've deployed a secure device but haven't!
| } | ||
|
|
||
| // Find partition, by partition name on GPT or by filesystem label on MBR. | ||
| async function findPartition( |
There was a problem hiding this comment.
Since that's soooo similar to findBootPartitionByName() of balena-config-json, how about avoiding the duplication by creating and exposing a more generic function like the one you did here?
We can then have findBootPartitionByName() use this new findPartition() by wiring in the names of interest for the partition.
Deny an attempt to preload an app into an image with secure boot enabled, and provide a message to the user. BalenaOS does not support this action.
Implementation includes a generic, callback-driven capability to explore a partition in
utils/explore-contentsmodule. Allows for the caller to determine success or failure.