Implement WebSocket Security BBEs #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ina-distribution into websocket-security
…ina-distribution into websocket-security
…ecurity Add BBEs related to WebSocket client security
ldclakmal
force-pushed
the
fix-security-bbes
branch
from
eeb5b69 to
9a67468
Compare
Bhashinee
reviewed
Jun 14, 2021
|
|
||
| public function main() returns error? { | ||
| check securedEP->writeTextMessage("Hello, World!"); | ||
| string response = check securedEP->readTextMessage(); |
There was a problem hiding this comment.
Suggested change
| string response = check securedEP->readTextMessage(); | |
| string textMessage = check securedEP->readTextMessage(); |
When we say the response isn't it more like getting a response for a request as in HTTP? Shall we keep it as textMessage? WDYT?
There was a problem hiding this comment.
+1. Fixed with 845ed03
Bhashinee
reviewed
Jun 14, 2021
Bhashinee
reviewed
Jun 14, 2021
examples/websocket-client-self-signed-jwt-auth/websocket_client_self_signed_jwt_auth.out
Outdated
Show resolved
Hide resolved
Bhashinee
reviewed
Jun 14, 2021
examples/websocket-service-jwt-auth/websocket_service_jwt_auth.server.out
Outdated
Show resolved
Hide resolved
Bhashinee
reviewed
Jun 14, 2021
examples/websocket-service-oauth2/websocket_service_oauth2.server.out
Outdated
Show resolved
Hide resolved
Co-authored-by: Bhashinee <[email protected]>
Bhashinee
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject was done for following BBEs:
WebSocket Security
Fixes ballerina-platform/ballerina-library#1421
Related to ballerina-platform/ballerina-library#584