Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Kafka and TCP Security BBEs #2033

Merged
merged 4 commits into from
Jul 1, 2021

Conversation

ldclakmal
Copy link
Member

Purpose

Improve Kafka and TCP Security BBEs consistent with rest of the security BBEs.

Related to: ballerina-platform/ballerina-library#584

@ldclakmal ldclakmal requested review from aashikam and Bhashinee July 1, 2021 04:26
@ldclakmal ldclakmal force-pushed the fix-security-bbes branch from cc28b47 to 22cdac5 Compare July 1, 2021 04:36
@Bhashinee
Copy link
Member

TCP changes LGTM.

@ldclakmal ldclakmal force-pushed the fix-security-bbes branch from be7acd9 to b5a7bd0 Compare July 1, 2021 10:50
Copy link
Contributor

@aashikam aashikam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kafka examples LGTM

@ldclakmal ldclakmal merged commit d35e80c into ballerina-platform:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants