Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Parallel Execution for GraphQL resolvers #4122

Open
ThisaruGuruge opened this issue Feb 22, 2023 · 5 comments · Fixed by ballerina-platform/module-ballerina-graphql#1256 or ballerina-platform/module-ballerina-graphql#2113
Open

Introduce Parallel Execution for GraphQL resolvers #4122

ThisaruGuruge opened this issue Feb 22, 2023 · 5 comments · Fixed by ballerina-platform/module-ballerina-graphql#1256 or ballerina-platform/module-ballerina-graphql#2113
Assignees
@DimuthuMadushan @MohamedSabthar
Labels
module/graphql Issues related to Ballerina GraphQL module Team/PCM Protocol connector packages related issues Type/Improvement

Comments

@ThisaruGuruge
Copy link
Member

Description:
GraphQL query resolvers are allowed for parallel execution according to the GraphQL spec. When the resource execution was implemented in Java, it was done in parallel. But since the execution logic is moved to Ballerina, the execution is done sequentially. To improve the performance of the GraphQL server, these query executions should be done in parallel again.
@ThisaruGuruge ThisaruGuruge added Type/Improvement module/graphql Issues related to Ballerina GraphQL module Team/PCM Protocol connector packages related issues labels Feb 22, 2023
@MohamedSabthar MohamedSabthar mentioned this issue Feb 27, 2023
Closed
@MohamedSabthar MohamedSabthar self-assigned this Feb 27, 2023
@MohamedSabthar MohamedSabthar moved this from BackLog to In Progress in Ballerina Team Main Board Feb 27, 2023
@MohamedSabthar MohamedSabthar mentioned this issue Mar 2, 2023
Merged
5 tasks
@MohamedSabthar MohamedSabthar moved this from In Progress to PR Sent in Ballerina Team Main Board Mar 3, 2023
@MohamedSabthar MohamedSabthar moved this from PR Sent to In Progress in Ballerina Team Main Board Mar 10, 2023
@MohamedSabthar MohamedSabthar moved this from In Progress to PR Sent in Ballerina Team Main Board Mar 10, 2023
@MohamedSabthar MohamedSabthar moved this from PR Sent to In Progress in Ballerina Team Main Board Mar 10, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Ballerina Team Main Board Mar 14, 2023
@ThisaruGuruge
Copy link
Member Author

ThisaruGuruge commented Aug 7, 2024 •
edited
Loading

I am reopening this as we have to introduce this back.

@ThisaruGuruge ThisaruGuruge reopened this Aug 7, 2024
@shafreenAnfar shafreenAnfar changed the title Re-introduce Parallel Execution for GraphQL resolvers Introduce Parallel Execution for GraphQL resolvers Aug 7, 2024
@DimuthuMadushan DimuthuMadushan self-assigned this Sep 4, 2024
@DimuthuMadushan DimuthuMadushan moved this from Done to In Progress in Ballerina Team Main Board Sep 4, 2024
@DimuthuMadushan DimuthuMadushan mentioned this issue Oct 14, 2024
Closed
7 tasks
@MohamedSabthar MohamedSabthar mentioned this issue Oct 15, 2024
Merged
7 tasks
@DimuthuMadushan DimuthuMadushan moved this from In Progress to PR Sent in Ballerina Team Main Board Oct 31, 2024
@MohamedSabthar
Copy link
Member

Closing as this is completed via ballerina-platform/module-ballerina-graphql#2067

@github-project-automation github-project-automation bot moved this from PR Sent to Done in Ballerina Team Main Board Nov 4, 2024
@MohamedSabthar
Copy link
Member

Reopening this issue as we need to port this change to the master

@MohamedSabthar MohamedSabthar reopened this Nov 4, 2024
@ThisaruGuruge
Copy link
Member Author

We also need to patch the 1.14.x (Ballerina 2201.10.x versions)

@ThisaruGuruge ThisaruGuruge mentioned this issue Dec 4, 2024
Merged
7 tasks
@ThisaruGuruge
Copy link
Member Author

Reopenning since this is not yet ported to 2201.10.x

@ThisaruGuruge ThisaruGuruge reopened this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimuthuMadushan DimuthuMadushan

@MohamedSabthar MohamedSabthar

Labels
module/graphql Issues related to Ballerina GraphQL module Team/PCM Protocol connector packages related issues Type/Improvement
Projects
Ballerina Team Main Board
Status: Done
Milestone
No milestone
3 participants
@DimuthuMadushan @ThisaruGuruge @MohamedSabthar