Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement service level interceptors using InterceptableService #4401

Closed
4 tasks done
dilanSachi opened this issue Apr 28, 2023 · 2 comments
Closed
4 tasks done

Implement service level interceptors using InterceptableService #4401

dilanSachi opened this issue Apr 28, 2023 · 2 comments
Assignees
Labels
module/http Team/PCM Protocol connector packages related issues Type/Task

Comments

@dilanSachi
Copy link
Contributor

dilanSachi commented Apr 28, 2023

Description:
For the details discussion, refer the original discussion [1].

  • Add InterceptableService to http module and get the service level interceptors using this initInterceptors() function.
  • Give a warning/compiler error when interceptors are added from both this function and the annotation
  • Deprecate the usage of having the interceptors in the annotation (might be provided by the compiler plugin)
  • Update the website and other samples

[1] #4300

@dilanSachi
Copy link
Contributor Author

Give a warning/compiler error when interceptors are added from both this function and the annotation,

For this better to give a compile error rather than a warning right? As we cannot decide on a order of the interceptors in the runtime.
@TharmiganK

@dilanSachi
Copy link
Contributor Author

Closing as this is completed

@github-project-automation github-project-automation bot moved this from PR Sent to Done in Ballerina Team Main Board May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/http Team/PCM Protocol connector packages related issues Type/Task
Projects
Archived in project
Development

No branches or pull requests

1 participant