Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the websub-code base according to code-review comments #1183

Closed
ayeshLK opened this issue Mar 28, 2021 · 0 comments · Fixed by ballerina-platform/module-ballerina-websub#159
Labels
module/websub Team/PCM Protocol connector packages related issues Type/Improvement Verson/SwanLakeDump All issues planned for Swan Lake GA release

Comments

@ayeshLK
Copy link
Member

ayeshLK commented Mar 28, 2021

Description:

  • According to the comments received on websub code review, update the code-base.

Describe your solution(s)

  • Implement constants for websub common-responses and use them throughout the module.
  • Use string-template to generate subscriber-callback-url.
  • Use included-record-params for websub:ListenerConfiguration in websub:Listener init method.
  • Use mime constants to check content-types in content-distribution.
  • Include support for x-form-urlencoded in content-distribution.
  • Mark parameters in RequestQueryParams record as optional.

Related Issues (optional):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/websub Team/PCM Protocol connector packages related issues Type/Improvement Verson/SwanLakeDump All issues planned for Swan Lake GA release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants