Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error log in update OAuth2 cache entry #1203

Closed
kasthuriraajan opened this issue Apr 5, 2021 · 0 comments · Fixed by ballerina-platform/module-ballerina-oauth2#129
Assignees
Labels
Area/Security Issues related to stdlib security module/oauth2 Team/PCM Protocol connector packages related issues Type/Improvement

Comments

@kasthuriraajan
Copy link

Description:
Change the error log message in an appropriate way.

Describe your problem(s)
Currently it shows error message as "Failed to access 'refreshToken' property from the JSON " along with the JSON property which has access token and scopes. But at some cases, there will not be a refresh_token property . In that cases this error log is inappropriate.

Describe your solution(s)
Change this error log as an appropriate message or a warning log message. As access token is sensitive one, we need to hide that from printing in log message.

Suggested Labels (optional):
module/oauth2 , type/improvement

Suggested Assignees (optional):
Chanaka Lakmal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/Security Issues related to stdlib security module/oauth2 Team/PCM Protocol connector packages related issues Type/Improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants