Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

websub:SubscriberService should notify the user when a subscription denied request received from the hub #2448

Closed
ayeshLK opened this issue Dec 1, 2021 · 0 comments · Fixed by ballerina-platform/module-ballerina-websub#468

Comments

@ayeshLK
Copy link
Member

ayeshLK commented Dec 1, 2021

Description:
Whenever websub:SubscriberService initiate a subscription, there are two request flows which could initiate:

  1. hub accepts the subscription and tries to verify the subscription attempt
  2. hub denies the subscription attempt

But, if the subscription is denied by the hub, there should be a notification for the user about the subscription denial. Currently this could be achieved by implementing onSubscriptionDenied remote method in websub:SubscriberService. But, since this method is optional, the websub:SubscriberService itself should log the subscription denial for the cases where onSubscriptionDenied is not implemented.

Affected Versions:
SL Beta 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant