-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit the application after service panics #1158
Exit the application after service panics #1158
Conversation
Codecov ReportBase: 80.50% // Head: 71.96% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1158 +/- ##
==========================================
- Coverage 80.50% 71.96% -8.54%
==========================================
Files 75 76 +1
Lines 5344 5379 +35
Branches 1233 1245 +12
==========================================
- Hits 4302 3871 -431
- Misses 629 1092 +463
- Partials 413 416 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
e8b2cbe
to
d5ea5d6
Compare
This reverts commit d5ea5d6.
ballerina-tests/tests/56_service_panic_after_send_error_service.bal
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add minor comment. Overall LGTM
…e.bal Co-authored-by: Danesh Kuruppu <[email protected]>
Purpose
Fixes ballerina-platform/ballerina-library#3604
Fixes ballerina-platform/ballerina-library#4047
Cannot add tests for this scenario since
System.exit
will exit the complete test suite.Examples
Checklist