Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit the application after service panics #1158

Merged
merged 12 commits into from
Feb 20, 2023

Conversation

dilanSachi
Copy link
Contributor

@dilanSachi dilanSachi commented Feb 6, 2023

Purpose

Fixes ballerina-platform/ballerina-library#3604
Fixes ballerina-platform/ballerina-library#4047

Cannot add tests for this scenario since System.exit will exit the complete test suite.

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 80.50% // Head: 71.96% // Decreases project coverage by -8.54% ⚠️

Coverage data is based on head (c8af65c) compared to base (b702fad).
Patch coverage: 58.62% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1158      +/-   ##
==========================================
- Coverage   80.50%   71.96%   -8.54%     
==========================================
  Files          75       76       +1     
  Lines        5344     5379      +35     
  Branches     1233     1245      +12     
==========================================
- Hits         4302     3871     -431     
- Misses        629     1092     +463     
- Partials      413      416       +3     
Impacted Files Coverage Δ
...n/java/io/ballerina/stdlib/grpc/GrpcConstants.java 100.00% <ø> (ø)
ballerina/auth_desugar.bal 50.00% <20.00%> (-42.46%) ⬇️
...b/grpc/callback/StreamingCallableUnitCallBack.java 78.94% <66.66%> (-4.19%) ⬇️
...tdlib/grpc/callback/UnaryCallableUnitCallBack.java 77.00% <66.66%> (-3.69%) ⬇️
ballerina/caller.bal 0.00% <0.00%> (-100.00%) ⬇️
ballerina/compression.bal 0.00% <0.00%> (-100.00%) ⬇️
ballerina/grpc_commons.bal 0.00% <0.00%> (-100.00%) ⬇️
ballerina/auth_listener_jwt_auth_handler.bal 0.00% <0.00%> (-100.00%) ⬇️
ballerina/service_endpoint.bal 0.00% <0.00%> (-96.63%) ⬇️
ballerina/streaming_client.bal 0.00% <0.00%> (-95.84%) ⬇️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dilanSachi dilanSachi marked this pull request as ready for review February 7, 2023 08:02
Copy link
Member

@daneshk daneshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add minor comment. Overall LGTM

@dilanSachi dilanSachi merged commit a35b39c into ballerina-platform:master Feb 20, 2023
@dilanSachi dilanSachi deleted the exit-on-panic branch February 20, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log the errors returning from the service Exit the service when a panic happens inside
2 participants