Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make auth handlers isolated #245

Merged
merged 2 commits into from
May 21, 2021
Merged

Make auth handlers isolated #245

merged 2 commits into from
May 21, 2021

Conversation

ldclakmal
Copy link
Member

Purpose

$subject
Related to ballerina-platform/ballerina-library#584

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

@daneshk daneshk changed the base branch from master to isolation May 21, 2021 12:41
@daneshk daneshk changed the base branch from isolation to master May 21, 2021 12:50
@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #245 (293b902) into master (53af207) will decrease coverage by 0.01%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #245      +/-   ##
============================================
- Coverage     71.53%   71.52%   -0.02%     
- Complexity     1021     1022       +1     
============================================
  Files           122      122              
  Lines          6233     6234       +1     
  Branches       1062     1067       +5     
============================================
  Hits           4459     4459              
- Misses         1339     1342       +3     
+ Partials        435      433       -2     
Impacted Files Coverage Δ Complexity Δ
...h_listener_ldap_user_store_basic_auth_provider.bal 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...allerina/auth_client_bearer_token_auth_handler.bal 87.50% <66.66%> (-12.50%) 0.00 <0.00> (ø)
grpc-ballerina/auth_client_basic_auth_handler.bal 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
grpc-ballerina/auth_client_oauth2_handler.bal 90.00% <100.00%> (ø) 0.00 <0.00> (ø)
...erina/auth_client_self_signed_jwt_auth_handler.bal 90.00% <100.00%> (ø) 0.00 <0.00> (ø)
grpc-ballerina/auth_listener_jwt_auth_handler.bal 85.00% <100.00%> (ø) 0.00 <0.00> (ø)
grpc-ballerina/auth_listener_oauth2_handler.bal 83.33% <100.00%> (ø) 0.00 <0.00> (ø)
grpc-ballerina/client_endpoint.bal 85.50% <0.00%> (-1.45%) 0.00% <0.00%> (ø%)
...main/java/org/ballerinalang/net/grpc/GrpcUtil.java 51.59% <0.00%> (-0.46%) 22.00% <0.00%> (ø%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53af207...293b902. Read the comment docs.

@ldclakmal ldclakmal merged commit f491b71 into master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants