Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CallerInfo annotation type validation #327

Merged
merged 3 commits into from
Apr 21, 2021

Conversation

chamil321
Copy link
Contributor

@chamil321 chamil321 commented Apr 21, 2021

Purpose

$subject
Fixes ballerina-platform/ballerina-library#744
Related to ballerina-platform/ballerina-library#1102

Related Issues

ballerina-platform/ballerina-library#1281
ballerina-platform/ballerina-lang#30131

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

@chamil321 chamil321 force-pushed the com-plug branch 2 times, most recently from ab461c4 to 9d3c6ef Compare April 21, 2021 05:46
@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #327 (ac55ebe) into master (cb735d1) will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #327      +/-   ##
============================================
- Coverage     58.29%   58.13%   -0.16%     
+ Complexity     2482     2474       -8     
============================================
  Files           371      371              
  Lines         18509    18509              
  Branches       3954     3954              
============================================
- Hits          10789    10760      -29     
- Misses         7069     7100      +31     
+ Partials        651      649       -2     
Impacted Files Coverage Δ Complexity Δ
http-ballerina/http_annotation.bal 100.00% <ø> (ø) 0.00 <0.00> (ø)
http-ballerina/http_commons.bal 87.17% <ø> (ø) 0.00 <0.00> (ø)
...ransport/contractimpl/common/states/StateUtil.java 52.94% <0.00%> (-25.50%) 11.00% <0.00%> (-2.00%)
...ansport/contractimpl/HttpOutboundRespListener.java 68.88% <0.00%> (-4.45%) 12.00% <0.00%> (-1.00%)
...contractimpl/listener/states/ReceivingHeaders.java 48.97% <0.00%> (-4.09%) 6.00% <0.00%> (-1.00%)
...ransport/message/DefaultFullHttpMessageFuture.java 60.00% <0.00%> (-4.00%) 5.00% <0.00%> (-1.00%)
...tractimpl/sender/ConnectionAvailabilityFuture.java 62.19% <0.00%> (-3.66%) 22.00% <0.00%> (-2.00%)
...alang/net/transport/message/HttpCarbonMessage.java 63.84% <0.00%> (-2.83%) 58.00% <0.00%> (-3.00%)
...net/transport/message/HttpMessageDataStreamer.java 71.59% <0.00%> (-2.28%) 6.00% <0.00%> (ø%)
...nsport/contractimpl/DefaultHttpResponseFuture.java 62.33% <0.00%> (-1.95%) 25.00% <0.00%> (-1.00%)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ef8af...ac55ebe. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve compiler plugin to validate response type against http:CallerInfo annotation value
3 participants