Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make auth handlers isolated #407

Merged
merged 4 commits into from
May 21, 2021
Merged

Conversation

ldclakmal
Copy link
Member

Purpose

$subject
Related to ballerina-platform/ballerina-library#584

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

@ldclakmal ldclakmal requested a review from chamil321 May 21, 2021 12:38
@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #407 (f6eeac1) into master (4a60e3b) will increase coverage by 31.05%.
The diff coverage is 83.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #407       +/-   ##
=============================================
+ Coverage     45.73%   76.78%   +31.05%     
+ Complexity     1811       62     -1749     
=============================================
  Files           268      319       +51     
  Lines         12127    16255     +4128     
  Branches       1412     3738     +2326     
=============================================
+ Hits           5546    12482     +6936     
+ Misses         6097     3054     -3043     
- Partials        484      719      +235     
Impacted Files Coverage Δ Complexity Δ
...h_listener_ldap_user_store_basic_auth_provider.bal 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...allerina/auth_client_bearer_token_auth_handler.bal 91.66% <66.66%> (ø) 0.00 <0.00> (?)
http-ballerina/auth_client_basic_auth_handler.bal 86.95% <100.00%> (ø) 0.00 <0.00> (?)
http-ballerina/auth_client_oauth2_handler.bal 86.95% <100.00%> (ø) 0.00 <0.00> (?)
...erina/auth_client_self_signed_jwt_auth_handler.bal 86.95% <100.00%> (ø) 0.00 <0.00> (?)
...th_listener_file_user_store_basic_auth_handler.bal 95.83% <100.00%> (ø) 0.00 <0.00> (?)
http-ballerina/auth_listener_jwt_auth_handler.bal 96.00% <100.00%> (ø) 0.00 <0.00> (?)
http-ballerina/auth_listener_oauth2_handler.bal 87.87% <100.00%> (ø) 0.00 <0.00> (?)
...mpl/listener/states/http2/ReceivingEntityBody.java 55.00% <0.00%> (-15.00%) 0.00% <0.00%> (-8.00%)
http-ballerina/auth_desugar.bal 87.50% <0.00%> (ø) 0.00% <0.00%> (?%)
... and 176 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a60e3b...f6eeac1. Read the comment docs.

@ldclakmal ldclakmal merged commit 276cba9 into ballerina-platform:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants