Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for listener auth with LDAP user store #451

Merged
merged 6 commits into from
Jun 11, 2021

Conversation

ldclakmal
Copy link
Member

@ldclakmal ldclakmal commented Jun 11, 2021

Purpose

$subject
Related to: ballerina-platform/ballerina-library#584

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #451 (d26c496) into master (deff3bd) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #451      +/-   ##
============================================
+ Coverage     77.10%   77.24%   +0.14%     
  Complexity       62       62              
============================================
  Files           318      318              
  Lines         16390    16390              
  Branches       3847     3847              
============================================
+ Hits          12637    12661      +24     
+ Misses         3045     3012      -33     
- Partials        708      717       +9     
Impacted Files Coverage Δ
http-ballerina/auth_desugar.bal 96.59% <100.00%> (+9.09%) ⬆️
...th_listener_ldap_user_store_basic_auth_handler.bal 95.65% <100.00%> (ø)
...sport/message/ClientRemoteFlowControlListener.java 52.63% <0.00%> (-15.79%) ⬇️
...ansport/message/DefaultBackPressureObservable.java 64.28% <0.00%> (-7.15%) ⬇️
...tractimpl/sender/ConnectionAvailabilityFuture.java 69.51% <0.00%> (-4.88%) ⬇️
...nsport/contractimpl/DefaultHttpResponseFuture.java 72.72% <0.00%> (-2.60%) ⬇️
...net/transport/message/HttpMessageDataStreamer.java 75.00% <0.00%> (-2.28%) ⬇️
...alang/net/transport/message/HttpCarbonMessage.java 87.00% <0.00%> (-1.70%) ⬇️
...alang/net/http/service/signature/ParamHandler.java 86.02% <0.00%> (-1.48%) ⬇️
...ng/net/http/client/actions/AbstractHTTPAction.java 65.73% <0.00%> (-0.80%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deff3bd...d26c496. Read the comment docs.

@ldclakmal ldclakmal marked this pull request as ready for review June 11, 2021 11:50
@ldclakmal ldclakmal requested a review from chamil321 June 11, 2021 11:51
@ldclakmal ldclakmal merged commit 659a2cd into ballerina-platform:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants