From 4f1ed669326e025a5587f604edd0b5fc548f09cf Mon Sep 17 00:00:00 2001 From: vil02 Date: Mon, 16 Oct 2023 22:17:03 +0200 Subject: [PATCH 1/2] [Automated] Update the native jar versions --- ballerina/Dependencies.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ballerina/Dependencies.toml b/ballerina/Dependencies.toml index 66df39ea..850d1408 100644 --- a/ballerina/Dependencies.toml +++ b/ballerina/Dependencies.toml @@ -5,7 +5,7 @@ [ballerina] dependencies-toml-version = "2" -distribution-version = "2201.8.0-20230830-220400-8a7556d8" +distribution-version = "2201.8.0-20230908-135700-74a59dff" [[package]] org = "ballerina" From 00a2c99504b89f6a9d08c538191d49bcf23c7a48 Mon Sep 17 00:00:00 2001 From: vil02 Date: Mon, 16 Oct 2023 22:20:23 +0200 Subject: [PATCH 2/2] Make some Java classes proper utilities Made the design cleaner by marking Java classes as `final` and explicitly declaring their default constructors as `private`. This change makes the code coverage reports more accurate. Closes #4940. --- changelog.md | 1 + .../java/io/ballerina/stdlib/mime/util/MimeConstants.java | 4 +++- .../main/java/io/ballerina/stdlib/mime/testutils/Assert.java | 4 +++- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/changelog.md b/changelog.md index 4a42b36b..3d6a5838 100644 --- a/changelog.md +++ b/changelog.md @@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), ## Changed - [Change `com.sun.activation:jakarta.activation` to `jakarta.activation:jakarta.activation-api`](https://github.com/ballerina-platform/ballerina-standard-library/issues/4789) +- [Make some of the Java classes proper utility classes](https://github.com/ballerina-platform/ballerina-standard-library/issues/4940) ## [2.6.0] - 2022-02-20 diff --git a/native/src/main/java/io/ballerina/stdlib/mime/util/MimeConstants.java b/native/src/main/java/io/ballerina/stdlib/mime/util/MimeConstants.java index c5dafdcf..eabc0e4e 100644 --- a/native/src/main/java/io/ballerina/stdlib/mime/util/MimeConstants.java +++ b/native/src/main/java/io/ballerina/stdlib/mime/util/MimeConstants.java @@ -28,7 +28,9 @@ /** * Constants related to MIME. */ -public class MimeConstants { +public final class MimeConstants { + + private MimeConstants() {} public static final String ENTITY = "Entity"; public static final String MEDIA_TYPE = "MediaType"; diff --git a/test-utils/src/main/java/io/ballerina/stdlib/mime/testutils/Assert.java b/test-utils/src/main/java/io/ballerina/stdlib/mime/testutils/Assert.java index c0f3a33a..e515c8b6 100644 --- a/test-utils/src/main/java/io/ballerina/stdlib/mime/testutils/Assert.java +++ b/test-utils/src/main/java/io/ballerina/stdlib/mime/testutils/Assert.java @@ -3,7 +3,9 @@ /** * Contains assert functions used by mime test cases. */ -public class Assert { +public final class Assert { + + private Assert() {} public static void assertEquals(Object actual, Object expected) { if (!areEqual(actual, expected)) {