Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logs in WebSub Module #280

Merged
merged 16 commits into from
Jun 15, 2021

Conversation

ayeshLK
Copy link
Member

@ayeshLK ayeshLK commented Jun 11, 2021

Purpose

$subject

Fixes #1450
Fixes #1406

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
    Added tests N/A

@ayeshLK ayeshLK changed the title Log error when the return from the remote method leads to an error Update logs in WebSub Module Jun 11, 2021
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #280 (5c9b5a0) into master (20f31aa) will increase coverage by 0.35%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
+ Coverage   87.59%   87.95%   +0.35%     
==========================================
  Files          10       10              
  Lines         524      523       -1     
  Branches      289      287       -2     
==========================================
+ Hits          459      460       +1     
+ Misses         65       63       -2     
Impacted Files Coverage Δ
websub-ballerina/request_processor.bal 86.25% <0.00%> (ø)
websub-ballerina/subscriber_client.bal 86.66% <ø> (-0.44%) ⬇️
websub-ballerina/sub_listener.bal 90.32% <100.00%> (+1.70%) ⬆️
websub-ballerina/utils.bal 91.26% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20f31aa...5c9b5a0. Read the comment docs.

@chamil321 chamil321 merged commit d029301 into ballerina-platform:master Jun 15, 2021
public interface Constants {
String PACKAGE_ORG = "ballerina";
String PACKAGE_NAME = "websub";

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty line ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. Will fix this with next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants