Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added encoder support, fixed keymap between via and Cory Dora mapping QK_BOOT to flash #1

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

layogtima
Copy link

@layogtima layogtima commented Sep 22, 2024

Description

Changes,

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • [✔] Keyboard (addition or update)
  • [✔] Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [✔] My code follows the code style of this project: C, Python
  • [✔] I have read the PR Checklist document and have made the appropriate changes.
  • [✔] My change requires a change to the documentation.
  • [✔] I have updated the documentation accordingly.
  • [✔] I have read the CONTRIBUTING document.
  • [✔] I have added tests to cover my changes.
  • [✔] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

…. Added

QK_BOOT to flash without having to open the entire case up.
@layogtima
Copy link
Author

@balub see if this works!

@layogtima
Copy link
Author

Removed redundant config repeats. Fixed the via.json file issue; rows need to be 4!

Copy link
Owner

@balub balub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@balub balub merged commit 54e9a13 into balub:master Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants