Bug Fixed: <header> being stripped. Simple update to RegEX #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added word bound to htmlCompat(). This is because the regex previously matched the html5 <header> tag and striped it out. Now '<head ' and '<head>' will match and '<header ' and '<header>' will not match so <header> will not longer be stripped out.
Added word bound to htmlCompat(). This is because the regex previously matched the html5 <header> tag and striped it out. Now '<head ' and '<head>' will match and '<header ' and '<header>' will not match so <header> will not longer be stripped out.
balupton
added a commit
that referenced
this pull request
Dec 28, 2012
Bug Fixed: <header> being stripped. Simple update to RegEX
|
Merged :) Thanks so much! Never new of the bound word thing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for the awesome script! Please commit this bug fix. I have simply updated the existing RegEX to include \b word boundary.
I noticed that when a requested page contained a html5 header element it was being stripped out. The is because of the RegEX used in the replace function found in htmlCompat.
"<title>test regex</title>\n
content".replace(/<(html|head|body|title|meta)\b/gi,'<div');Output:
"
Will match '<head ' and '' but not '<header ' or '
'.Thanks,
Kalarrs Topham
Given this requested page:
A article headerBefore Bug Fix: (header tag was stripped out)
After Bug Fix:
A article header
A section of the article