Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP-Builder: provide Storybook stories for @jsonforms/example #99

Closed
bangank36 opened this issue Aug 17, 2023 · 1 comment
Closed

WP-Builder: provide Storybook stories for @jsonforms/example #99

bangank36 opened this issue Aug 17, 2023 · 1 comment

Comments

@bangank36
Copy link
Owner

bangank36 commented Aug 17, 2023

Summary

I can't found the hosted version of the example package, and it worth provide a dedicated Storybook page for @jsonforms

  • To display all the schema example in example packages plus the selection between renderers
  • To render the kitchensink for gutenberg renderer for demostrating this project

Questions

  • Can we generate the Stories on the sidebar dynamically?
  • If not, should we create a script to iterate over examples and generate .mdx dynamically?
  • Similar concern
  • developer from wix
  • I think just by supporting similar method like storiesOf ladle could be used for such cases or alternative solution that would support generating bunch of stories in a file based on some data structure.

Follow up tasks

With the initial stories has been merged, we need to improve the stories as below

  • Improve the stories generator
    • Use promises for the file reader
    • Use proper JS template instead of txt file
  • Update the main story to introduce about jsonforms and the renderers
  • Create github actions to auto generate the examples files ?
  • Export the story config into separate file and import to stories
    • Remove Controls since it is long, maybe provide the description for the args
  • Create different stories for renderers, so far Primary is used for Mui, we should change the name accordingly

Reference

@bangank36 bangank36 converted this from a draft issue Aug 17, 2023
@bangank36
Copy link
Owner Author

Relevant PR has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant