Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question about Include Guards #473

Closed
Naegolus opened this issue Aug 9, 2022 · 2 comments · Fixed by #474
Closed

Question about Include Guards #473

Naegolus opened this issue Aug 9, 2022 · 2 comments · Fixed by #474

Comments

@Naegolus
Copy link

Naegolus commented Aug 9, 2022

Is there a specific reason why there is an include guard in re.h only?

Part of the include tree:

  • re.h
    • re_async.h (unguarded)
    • re_main.h (unguarded)
      • re_async.h (unguarded. Second time included) => Possible redefinitions?!

Isn't this kind of erroneous?
@sreimers sreimers mentioned this issue Aug 9, 2022
Merged
@sreimers
Copy link
Member

sreimers commented Aug 9, 2022

Thanks for report, is fixed now.

@Naegolus
Copy link
Author

Naegolus commented Aug 9, 2022

Wooow. That was fast. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

async: add guard baresip/re
2 participants
@sreimers @Naegolus