Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel Horizon breaks if Debugbar is loaded first and collects mail #682

Closed
fredlahde opened this issue Jul 26, 2017 · 4 comments
Closed

Comments

@fredlahde
Copy link

If the debugbar service provider is loaded before the horizon package and the mail collector is set to true, horizon breaks.

In Laravel\Horizon\WaitTimeCalculator@timeToClearFor() Horizon tries to get a Laravel\Horizon\RedisQueue to call readyNow() on it. For some reasons, it get's a Illuminate\Queue\RedisQueue instead, which does not offer this method.

This leads to the following exception: Call to undefined method Illuminate\Queue\RedisQueue::readyNow()

Surprisingly, this only happens when:

a) The debugbar Service provider is loaded BEFORE horizon
b) The mail collector is activated

Versions:

Laravel dev-master @ 2876087527
Debugbar dev-master @ d2c6e2c
Horizon 0.1.0

If you need further assistance in debugging this, im happy to provide more info.

@barryvdh
Copy link
Owner

And I can debug this with a clean install op 5.5 with horizon and debugbar?

@fredlahde
Copy link
Author

Yes

@barryvdh
Copy link
Owner

Submitted a PR upstream. Can you try it out?

@fredlahde
Copy link
Author

Tried it.

Solves the issue completely for me. Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants