Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cryptic explanation #11

Open
adammunoz opened this issue May 30, 2022 · 2 comments
Open

fix cryptic explanation #11

adammunoz opened this issue May 30, 2022 · 2 comments

Comments

@adammunoz
Copy link

https://github.com/basaldev/custom-service-template/blob/66fcc938921da49fe0125a2b5d087305d97e2083/index.js#L72

I'm not sure what this means.

@basal-alex
Copy link
Contributor

  util.createRoutes(ROUTES, {
    // 👇 this is required to run the service, should probably not be or
    // should be logOptions
    logOpts: {
      version: VERSION_INFO,
      name: SERVICE_NAME,
    },
  })
);

yeah this is for the sdk team actually, I will make a task on the backlog for him but in my opinion:

  1. Its shouldn't be required (app will not run)
  2. IF its has to be required then it should be logOpts should be logOptions

@basal-alex
Copy link
Contributor

@basalmarty fyi 😘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants