From 93e1e908674756aba98517413483f14e90e7801f Mon Sep 17 00:00:00 2001 From: Markus Hofauer Date: Tue, 17 Dec 2024 21:55:30 +0100 Subject: [PATCH] Move --nolegacy_external_runfiles to version specific rc files --- .aspect/bazelrc/bazel6.bazelrc | 8 ++++++++ .aspect/bazelrc/bazel7.bazelrc | 8 ++++++++ .aspect/bazelrc/performance.bazelrc | 8 -------- 3 files changed, 16 insertions(+), 8 deletions(-) diff --git a/.aspect/bazelrc/bazel6.bazelrc b/.aspect/bazelrc/bazel6.bazelrc index b2ce84dbd..e377913dd 100644 --- a/.aspect/bazelrc/bazel6.bazelrc +++ b/.aspect/bazelrc/bazel6.bazelrc @@ -44,3 +44,11 @@ build --incompatible_remote_results_ignore_disk build --experimental_allow_tags_propagation fetch --experimental_allow_tags_propagation query --experimental_allow_tags_propagation + +# Do not build runfiles symlink forests for external repositories under +# `.runfiles/wsname/external/repo` (in addition to `.runfiles/repo`). This reduces runfiles & +# sandbox creation times & prevents accidentally depending on this feature which may flip to off by +# default in the future. Note, some rules may fail under this flag, please file issues with the rule +# author. +# Docs: https://bazel.build/reference/command-line-reference#flag--legacy_external_runfiles +build --nolegacy_external_runfiles diff --git a/.aspect/bazelrc/bazel7.bazelrc b/.aspect/bazelrc/bazel7.bazelrc index dbd40ee84..0a263625b 100644 --- a/.aspect/bazelrc/bazel7.bazelrc +++ b/.aspect/bazelrc/bazel7.bazelrc @@ -13,3 +13,11 @@ common --check_direct_dependencies=off # build. # Docs: https://bazel.build/reference/command-line-reference#flag--reuse_sandbox_directories build --reuse_sandbox_directories + +# Do not build runfiles symlink forests for external repositories under +# `.runfiles/wsname/external/repo` (in addition to `.runfiles/repo`). This reduces runfiles & +# sandbox creation times & prevents accidentally depending on this feature which may flip to off by +# default in the future. Note, some rules may fail under this flag, please file issues with the rule +# author. +# Docs: https://bazel.build/reference/command-line-reference#flag--legacy_external_runfiles +build --nolegacy_external_runfiles diff --git a/.aspect/bazelrc/performance.bazelrc b/.aspect/bazelrc/performance.bazelrc index fc404c2fb..56749dd19 100644 --- a/.aspect/bazelrc/performance.bazelrc +++ b/.aspect/bazelrc/performance.bazelrc @@ -5,14 +5,6 @@ # Docs: https://bazel.build/reference/command-line-reference#flag--reuse_sandbox_directories build --experimental_reuse_sandbox_directories -# Do not build runfiles symlink forests for external repositories under -# `.runfiles/wsname/external/repo` (in addition to `.runfiles/repo`). This reduces runfiles & -# sandbox creation times & prevents accidentally depending on this feature which may flip to off by -# default in the future. Note, some rules may fail under this flag, please file issues with the rule -# author. -# Docs: https://bazel.build/reference/command-line-reference#flag--legacy_external_runfiles -build --nolegacy_external_runfiles - # Avoid creating a runfiles tree for binaries or tests until it is needed. # Docs: https://bazel.build/reference/command-line-reference#flag--build_runfile_links # See https://github.com/bazelbuild/bazel/issues/6627