Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing srcs in BUILD file #2

Closed
andrewkatson opened this issue Apr 3, 2024 · 4 comments · Fixed by #3
Closed

Missing srcs in BUILD file #2

andrewkatson opened this issue Apr 3, 2024 · 4 comments · Fixed by #3
Labels

Comments

@andrewkatson
Copy link

I am unfamiliar with bazel's inner workings and want to help this project so can you explain why no srcs section of BUILD files like https://github.com/bazelboost/thread/blob/bazelboost-1.83.0/BUILD.bazel.

I am asking because I am trying to migrate my build of a large repo from nelhage boost to this one and during linking I am getting a lot of "Undefined symbols for architecture arm64" and am going to try and fix it.

If you have any pointers of how to address this then please let me know.

@zaucy
Copy link
Member

zaucy commented Apr 3, 2024

Lots of these bazel modules were auto generated and have some errors. Generally speaking I've relied on community members notifying of an issue (as you've done!) and fixing them as they come up. Feel free to submit a PR with a fix or if you have some patience I'll get to it eventually :)

I've transfered your issue to the thread repository instead of the registry repository.

@zaucy zaucy transferred this issue from bazelboost/registry Apr 3, 2024
@zaucy zaucy added the bug label Apr 3, 2024
@zaucy zaucy changed the title Why no srcs Missing srcs in BUILD file Apr 3, 2024
@zaucy
Copy link
Member

zaucy commented Apr 3, 2024

If you are going to try and fix some repositories that would be great.

You can take some reference some other modules that are more complete such as https://github.com/bazelboost/process (although not fully complete.)

Each bazelboost repository should have tests in the test folder (if it exists). It should include a MODULE.bazel and one or more BUILD.bazel files defining the tests. The GitHub actions should automatically run them. Adding a couple tests has been the best way for testing if the main module is compiling correctly.

@andrewkatson
Copy link
Author

Okay awesome! I will get on it as I find things.

@zaucy zaucy linked a pull request Apr 4, 2024 that will close this issue
@andrewkatson
Copy link
Author

Going to close this since it is already being addressed elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants