Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

When generating BUILD files, Put abstract test classes into java_library, not java_test #4

Open
cgrushko opened this issue Sep 22, 2017 · 3 comments
Open

When generating BUILD files, Put abstract test classes into java_library, not java_test #4

cgrushko opened this issue Sep 22, 2017 · 3 comments

Comments

@cgrushko
Copy link
Contributor

No description provided.

@cgrushko cgrushko changed the title Do not put abstract test classes into java_test - they should be java_library Put abstract test classes into java_library, not java_test Sep 22, 2017
@petroseskinder
Copy link
Member

What abstract test classes are you referring to? There are no abstract classes in src/test/java/com/google/devtools/build/bfg

@cgrushko
Copy link
Contributor Author

I refer to abstract classes in projects that BFG is invoked on, such as JavaRx (which I'm playing with to uncover bugs in BFG).

@petroseskinder
Copy link
Member

Ohh. Can you clarify that within the description of the issue?

Because my previous interpretation was that you were referring to source files and rules within the BUILD_file_generator project.

@cgrushko cgrushko changed the title Put abstract test classes into java_library, not java_test When generating BUILD files, Put abstract test classes into java_library, not java_test Sep 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cgrushko @petroseskinder