Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypick cc_shared_library fixes into 6.1 #17444

Closed
oquenchil opened this issue Feb 8, 2023 · 1 comment
Closed

Cherrypick cc_shared_library fixes into 6.1 #17444

oquenchil opened this issue Feb 8, 2023 · 1 comment
Assignees
@oquenchil
Labels
P1 I'll work on this now. (Assignee required) potential 5.x cherry-picks Potential cherry-picks for the next 5.x release. We'll consider a new 5.x release if enough issues g team-Rules-CPP Issues for C++ rules type: process

Comments

@oquenchil
Copy link
Contributor

oquenchil commented Feb 8, 2023 •
edited
Loading

All of these are either bug fixes or compatible changes that will allow users to start migrating their builds earlier before the experimental flag for cc_shared_library is removed:

5ba2d25
9815b76
68aad18
4ed6327
@oquenchil oquenchil added P1 I'll work on this now. (Assignee required) type: process team-Rules-CPP Issues for C++ rules labels Feb 8, 2023
@oquenchil oquenchil self-assigned this Feb 8, 2023
@oquenchil oquenchil mentioned this issue Feb 8, 2023
Merged
@Wyverald Wyverald added the potential 5.x cherry-picks Potential cherry-picks for the next 5.x release. We'll consider a new 5.x release if enough issues g label Feb 8, 2023
@keertk keertk removed this from the 6.1.0 release blockers milestone Feb 19, 2023
@meteorcloudy
Copy link
Member

I guess this is done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oquenchil oquenchil

Labels
P1 I'll work on this now. (Assignee required) potential 5.x cherry-picks Potential cherry-picks for the next 5.x release. We'll consider a new 5.x release if enough issues g team-Rules-CPP Issues for C++ rules type: process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Wyverald @meteorcloudy @oquenchil @keertk