Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing env variable NUM_JOBS for cargo build script #1215

Closed
jgao54 opened this issue Mar 23, 2022 · 1 comment · Fixed by #1216
Closed

Missing env variable NUM_JOBS for cargo build script #1215

jgao54 opened this issue Mar 23, 2022 · 1 comment · Fixed by #1216

Comments

@jgao54
Copy link

jgao54 commented Mar 23, 2022

While using rules_rust with cargo-raze, I encountered an issue where the build script for a dependency crate jemalloc-sys 0.3.2 expects env var NUM_JOBS, which cargo sets by default for build scripts.

Not sure if NUM_JOBS is intentionally left out from cargo_build_script_runner/bin.rs or not -- happy to create a PR to add it.

There's also a related issue tracked in cargo-raze to support passing in custom build env vars. However, given this is a default cargo environment variable this might be a better place to add it.

@illicitonion
Copy link
Collaborator

Good catch, thanks for the bug report! Fixed in #1216 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants