Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip ensure return check when ensure has no body #333

Merged

Conversation

eitoball
Copy link
Contributor

@eitoball eitoball commented Jul 4, 2013

This PR should fix a case that Lint::EnsureReturn throws an exception when ensure clause has no body like

begin
  something
ensure
end

@bbatsov
Copy link
Collaborator

bbatsov commented Jul 4, 2013

Looks good. Please, add an entry about the bugfix in the Changelog.

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling 2d1655aaf82675e5184d1a19c7531546ce3f5407 on eitoball:skip_check_when_ensure_has_no_body into 09b0571 on bbatsov:master.

@eitoball
Copy link
Contributor Author

eitoball commented Jul 4, 2013

Looks good. Please, add an entry about the bugfix in the Changelog.

Thank you for checking out. Is 4e0fd65 okay?

@bbatsov
Copy link
Collaborator

bbatsov commented Jul 4, 2013

Yep, it's great. Please, squash the two commits into one rebasing on top of the current master and I'll have the PR merged.

@eitoball
Copy link
Contributor Author

eitoball commented Jul 4, 2013

Yep, it's great. Please, squash the two commits into one rebasing on top of the current master and I'll have the PR merged.

Done.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 9a6cd9f on eitoball:skip_check_when_ensure_has_no_body into d8026cf on bbatsov:master.

bbatsov added a commit that referenced this pull request Jul 4, 2013
Skip ensure return check when ensure has no body
@bbatsov bbatsov merged commit 1d18598 into rubocop:master Jul 4, 2013
@bbatsov
Copy link
Collaborator

bbatsov commented Jul 4, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants