Problem with "Indent when as deep as case"

[ggarnier]

I have a case statement where the return value is assigned to a variable. I'm getting an "Indent when as deep as case" warning. This is the code:

output = case variable
when 'value1'
  'output1'
when 'value2'
  'output2'
else
  'output3'
end

The syntax Rubocop accepts is:

output = case variable
         when 'value1'
           'output1'
         when 'value2'
           'output2'
         else
           'output3'
         end

[bbatsov]

This is intentional and enforced for all similar expressions. You can change the code into:

output = 
  case variable
  when 'value1'
    'output1'
  when 'value2'
    'output2'
  else
    'output3'
  end

[ggarnier]

Shouldn't both syntaxes be accepted?

[bbatsov]

Perhaps. But definitely not at the same time.

[bbatsov]

@jonas054 Would you like to tackle this?

[jonas054]

Yes. I've seen 4 styles that people use: they indent when 0 or 1 step (a step is two spaces), and they do it relative to case or relative to end. I think I'll add two parameters to accommodate these styles.

CaseIndentation:
  # Valid values are: case, end
  IndentWhenRelativeTo: case
  IndentOneStep: false

1 (default):

output = case variable
         when 'value1'
           'output1'
         else
           'output2'
         end

2:

output = case variable
when 'value1'
  'output1'
else
  'output2'
end

3:

output = case variable
           when 'value1'
             'output1'
           else
             'output2'
         end

4:

output = case variable
  when 'value1'
    'output1'
  else
    'output2'
end